-
Notifications
You must be signed in to change notification settings - Fork 0
Add unit tests with GitHub Actions #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: hikarin522 <7986594+hikarin522@users.noreply.github.com>
Co-authored-by: hikarin522 <7986594+hikarin522@users.noreply.github.com>
|
@copilot テストが通ってないので修正してください |
Co-authored-by: hikarin522 <7986594+hikarin522@users.noreply.github.com>
include/fet/drain/to_container.hpp
Outdated
| template <class E> | ||
| constexpr void OnNext(C<E> &ctx, E &&e) const | ||
| template <class E, class T> | ||
| constexpr void OnNext(C<E> &ctx, T &&e) const | ||
| { | ||
| ctx.push_back(std::forward<E>(e)); | ||
| ctx.push_back(std::forward<T>(e)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot この変更は戻してください
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the OnNext method template changes in to_container.hpp back to the original implementation. The method now uses the original signature template <class E> constexpr void OnNext(C<E> &ctx, E &&e) const as requested.
Commit: f2b5d3a
Co-authored-by: hikarin522 <7986594+hikarin522@users.noreply.github.com>
|
@copilot mac と windows のテストは消してください |
Co-authored-by: hikarin522 <7986594+hikarin522@users.noreply.github.com>
|
@copilot rebase して下さい |
I'm unable to perform a rebase operation because it requires force push, which is not available in my environment. The branch needs to be rebased against the latest master branch that contains newer commits. Could you please perform the rebase manually, or would you prefer me to create a new branch with the changes applied to the latest master? |
|
@copilot masterブランチを取り込んでください |
# Conflicts: # .github/workflows/ci.yml
Merged the master branch successfully. The changes include:
Commit: 7ea369d |
This PR adds comprehensive unit testing to the fet C++ functional library using GitHub Actions, as requested in the issue.
What was added
Unit Tests (
test/unit_tests.cpp)Added functional tests that verify the library's core capabilities work as documented:
Enhanced CI Workflow
Added a new
unit-testsjob to.github/workflows/ci.ymlthat:Why this matters
The existing CI only verified that headers could be included without compilation errors. These new tests ensure that:
The tests focus on the library's main value proposition - LINQ-like functional data processing with pipe operator syntax - ensuring users can rely on the documented API.
Fixes #5.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.