Open
Conversation
Even when a sharescreen etc starts, the popup keeps the presentation container.
Finally it's fixed. Does this make other problems?
Seems to make no difference...
And add the comments on what is affected by these changes.
update 3.0.13
The style changing panel is now working properly.
Dev3.0.14 suppress notification
A warning on ignoring a graphql subscription error on the popup.
Almost all the styles in the popup had been duplicated before this change, making a dynamic style change difficult.
Merge PR bigbluebutton#23888 before the official merge. This will turn the WB tool button opaque/solid after a toolbar autohide toggle, both on the main window and on the popup. May occur a conflict when syncing to the main branch.
probably due to the removal of duplicated style copying, or dynamic stylesheet element injection by <StyleSheetManager> which is include in ReactDOM.createPortal.
Only for the popup.
To use Kosugi-Maru also in the main window
Previously, all the draw glyphs were replaced by KosugiMaru glyphs, even though the unicode range was specified in the public/stylesheets/fonts.css.
Adding the line
font-family: 'tldraw_draw', 'KosugiMaruSubset', sans-serif;
to the .tl-text-shape__wrapper[data-font='draw'] is critical.
Now KosugiMaru font is added at styles.css. Much simplified.
Dev3.0.14 add jpn font simplified
I didn't know requestAnimationFrame is actually window.requestAnimationFrame...
So that the bbb-icon fonts look a bit smaller
|
This pull request has conflicts ☹ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems remained
depending on browser and OS, fullscreen in the same monitor does not expand the presentation (if you move to another monitor, it works). If it happens, you click the screen then tldraw realizes and the screen size has changed (but not always...).resize by dragging the resize handles does not work (focus is lost); dom.ts in tldraw causes the problemstyle panel including the color picker does not work well. When mouse-down, the mouse-up event is not caught, behaving as if mouse is kept down when hovered over the button, picking up every color that mouse hover. The reason is in this file: tldraw-alpha30/packages/tldraw/src/lib/ui/components/primitives/ButtonPicker.tsxFonts are not properly loaded on the popup, e. g., the var(--tl-font-draw) font which is the default on latin languages.Frequent 3006 error from graphql since 3.0.13 or 14 (not happening on 3.0.11)Additional features
only for popup)