absorptionCoefficient_Generic: allow initialization of Xsect with other datatype than float#49
Open
Leberwurscht wants to merge 1 commit intohitranonline:masterfrom
Open
absorptionCoefficient_Generic: allow initialization of Xsect with other datatype than float#49Leberwurscht wants to merge 1 commit intohitranonline:masterfrom
Leberwurscht wants to merge 1 commit intohitranonline:masterfrom
Conversation
…er datatype than float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile=... argument of absorptionCoefficient_Generic in principle allows to supply custom line profiles. We would like to use that for complex-valued profiles, so that the phase upon transmission through a medium can also be calculated - however, this won't work currently because of the line
Xsect = zeros(number_of_points)
where Xsect is initialized as real-valued type. An easy fix would be to allow to initialize Xsect with an optional keyword argument, like suggested in this pull request.
This would allow the user to initialize Xsect manually and thus permit several additional use cases: