Open
Conversation
In Godot 4 const arrays cannot be modified so the EDGE_STACK variable should be var, not const.
This commit changes the types of various arrays from Pool* to Packed* to be compatible with Godot 4.
In Godot 4 the slice method's end index parameter is now exclusive. This commit updates the code to reflect that change.
This commit fixes a small type warning for Godot 4 by using the absf() method instead of abs().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the library to be compatible with Godot 4, which also fixes issue #5 .