-
Notifications
You must be signed in to change notification settings - Fork 39
Remove scope hack from JSBuilder #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LPTK
wants to merge
18
commits into
hkmc2
Choose a base branch
from
remove-scope-hacks
base: hkmc2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
OK. This will probably take a while... |
Member
|
Shall we push to this branch directly, or create another PR to this branch? |
Contributor
Author
|
@NeilKleistGao feel free to push directly! |
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
Fix quote & region scope problems
`Scoped` and tailrec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #356, we changed the IR so that local symbols are explicitly allocated in
Scopedblocks, instead of implicitly scoped. This makes the logic cleaner, resolves longstanding issues, and simplifies passes like deforestation (so they do not need to reimplement the logic to figure out what is bound where).However, the JSBuilder still had hacks in place to generate bindings for symbols that are missing a
Scopeddefining them. This was needed because not all parts of the compiler have been fully adapted toScopedyet. This PR disables the hacks and witnesses failures that seem mostly rerated to:registerTempSymbolin a few places).@bufferedannotation generates unscoped variables; Cc @AnsonYeung