Feature/dropwizard bundle #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…within the same package in preparation for adding a dropwizard bundle without repeating any code, but maintaining backward compatibility with SpringService use.
…/application's initialize method allowing improved customisability. See the other dropwizard bundles for advantages of this approach for supporting libraries.
… initialised during construction with delegating methods that are locally called (and passed through by default). This allows further customisation through subclassing for users of the library through an unpublished API.
…t before the rest of the configuration is loaded. This has been used to inject a StaticApplicationContext where bean data is loaded from the configuration - a further feature will add this with first class support within the library.
…hat this field is supposed to do
…ation entries and turns them into Spring beans, making sure this context is constructed immediately after the dropwizard Spring bean is created and populated.
…been configured (as well as created).
Collaborator
|
I'm personally liking the idea here. We generally have broken out Spring configurables to a separate properties file, but this helps keep it self contained and wouldn't require changing both the Spring XML and associated properties. Curious what @boneill42, @irieksts, or @pabrahamsson think. |
Contributor
|
Agreed, I like it. We need someone to pull it down and test it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comprises of 3 changes, all of which I needed to use this library with my dropwizard application.
The README.md has been updated with examples. I've released this into my private repository at 0.7.0 as it was a functional change.