Conversation
Drache93
force-pushed
the
search
branch
2 times, most recently
from
0fe27d4 to
c710340
Compare
Records are added with simhashed tokens for later searching
| } | ||
|
|
||
| async onsearchablerecordput(req) { | ||
| if (!req.target || !this.searchableRecords) return |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!req.target || !this.searchableRecords) return | |
| if (!req.target || !this.searchableRecords) return |
no req.reply(null) before return - intentional?
Author
There was a problem hiding this comment.
Yes, was intentional based on approach i saw on the other functions. req.reply(null) was added to onsearch so when we run https://github.com/holepunchto/hyperdht/pull/231/changes#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R192 there's no issues
Any downside?
Contributor
There was a problem hiding this comment.
no sure but if there's no req.reply called I'd have thought it could lead to a leak maybe, underlying stream wouldn't be ended?
Author
There was a problem hiding this comment.
Checked with @mafintosh , all good since same in the other functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records are added with simhashed tokens for later searching