Open
Conversation
Didericis
force-pushed
the
run-pear-main-field
branch
2 times, most recently
from
2f923a1 to
c7a2b0b
Compare
Didericis
force-pushed
the
run-pear-main-field
branch
from
c7a2b0b to
98b99c5
Compare
Didericis
reviewed
Feb 3, 2026
| } | ||
| await this.constructor.build(this, result.value) | ||
| // FIXME: modify pear-state instead | ||
| this.manifest.main = this.main |
Contributor
There was a problem hiding this comment.
Equivalent to this PR (can be removed once pear-state is updated) -> holepunchto/pear-state#6
Didericis
reviewed
Feb 3, 2026
| const bundle = await app.pod.bundle(state.entrypoint) | ||
| const bundle = await app.pod.bundle( | ||
| // FIXME: temporary demonstration of fix, should be removed | ||
| flags.pre ? state.entrypoint : path.join(state.entrypoint, state.main) |
Contributor
There was a problem hiding this comment.
logic that sets state.entrypoint should be doing this join, I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.