Skip to content

Electron release#18

Open
zippy wants to merge 4 commits intomainfrom
electron-release
Open

Electron release#18
zippy wants to merge 4 commits intomainfrom
electron-release

Conversation

@zippy
Copy link
Member

@zippy zippy commented Apr 16, 2021

Adds building as an electron app.

Thanks to Damien and Connor for most of the work on the electron packaging. Small changes to syn stuff, mostly in src/Syn.svelte and the release_build.sh script, which doesn't yet do anything but linux. It should actually take a parameter and pass through to the electron builder, as well, probably, as doing some sanity checks...

@zippy zippy requested review from qubist and robbiecarlton April 16, 2021 19:46
@zippy zippy changed the base branch from main to catchup April 16, 2021 19:51
@zippy zippy changed the base branch from catchup to main April 16, 2021 19:55
Copy link
Collaborator

@qubist qubist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but versions of Holochain in nix isn't compatible with other versions. See #26 for a fix for that

@zippy
Copy link
Member Author

zippy commented Sep 28, 2022

It would be nice to add this back in, but now it's way out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants