Skip to content

Conversation

@BarryThePenguin
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 28, 2025

⚠️ No Changeset found

Latest commit: 7a6f00f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const ajv = new Ajv()
const validate = ajv.compile(schema)

// @ts-expect-error not typed well
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there was a change in either v4.11.2 or v4.11.3 that caused the type of the validator function to change 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The validator type was changed to make the types correct. The type definition became complex. So using @ts-expect-error makes sense.

@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (5acf969) to head (7a6f00f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         111      111           
  Lines        3661     3661           
  Branches      967      956   -11     
=======================================
  Hits         3377     3377           
  Misses        250      250           
  Partials       34       34           
Flag Coverage Δ
ajv-validator 100.00% <ø> (ø)
arktype-validator 93.54% <ø> (ø)
auth-js 98.57% <ø> (ø)
bun-compress 18.91% <ø> (ø)
capnweb 60.71% <ø> (ø)
casbin 86.48% <ø> (ø)
class-validator 95.00% <ø> (ø)
clerk-auth 88.46% <ø> (ø)
cloudflare-access 100.00% <ø> (ø)
conform-validator 96.15% <ø> (ø)
effect-validator 100.00% <ø> (ø)
esbuild-transpiler 100.00% <ø> (ø)
event-emitter 100.00% <ø> (ø)
firebase-auth 96.61% <ø> (ø)
graphql-server 92.15% <ø> (ø)
hello 100.00% <ø> (ø)
mcp 90.60% <ø> (ø)
medley-router 90.90% <ø> (ø)
node-ws 80.68% <ø> (ø)
oauth-providers 92.48% <ø> (ø)
oidc-auth 96.44% <ø> (ø)
otel 93.65% <ø> (ø)
prometheus 90.24% <ø> (ø)
react-renderer 88.88% <ø> (ø)
sentry 77.27% <ø> (ø)
session 98.91% <ø> (ø)
standard-validator 96.10% <ø> (ø)
stytch-auth 100.00% <ø> (ø)
swagger-editor 73.68% <ø> (ø)
swagger-ui 95.00% <ø> (ø)
trpc-server 69.56% <ø> (ø)
tsyringe 100.00% <ø> (ø)
typebox-validator 100.00% <ø> (ø)
typedriver-validator 100.00% <ø> (ø)
typia-validator 87.75% <ø> (ø)
ua-blocker 90.00% <ø> (ø)
valibot-validator 84.61% <ø> (ø)
zod-openapi 93.79% <ø> (ø)
zod-validator 91.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MathurAditya724
Copy link
Contributor

MathurAditya724 commented Dec 29, 2025

Can we integrate catalogs? As described here - https://yarnpkg.com/features/catalogs

Happy to create a seperate PR for this

@BarryThePenguin
Copy link
Contributor Author

Can we integrate catalogs? As described here - https://yarnpkg.com/features/catalogs

Happy to create a seperate PR for this

Is there a specific problem you want to solve? Does dependabot support yarn catalogs?

Adopting catalogs makes sense, just wondering if there's anything we should be aware of. For example, switching to bun if it becomes feasible

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jan 1, 2026

Hey @BarryThePenguin Happy New Year!

Looks good to me. Thank you!

@yusukebe yusukebe merged commit 8cf4327 into honojs:main Jan 1, 2026
133 checks passed
@BarryThePenguin
Copy link
Contributor Author

🎆 Happy New Year! 🥳

@BarryThePenguin BarryThePenguin deleted the chore/upgrade-hono branch January 1, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants