-
Notifications
You must be signed in to change notification settings - Fork 277
chore: upgrade hono to 4.11.3 #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| const ajv = new Ajv() | ||
| const validate = ajv.compile(schema) | ||
|
|
||
| // @ts-expect-error not typed well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there was a change in either v4.11.2 or v4.11.3 that caused the type of the validator function to change 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The validator type was changed to make the types correct. The type definition became complex. So using @ts-expect-error makes sense.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 111 111
Lines 3661 3661
Branches 967 956 -11
=======================================
Hits 3377 3377
Misses 250 250
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we integrate catalogs? As described here - https://yarnpkg.com/features/catalogs Happy to create a seperate PR for this |
Is there a specific problem you want to solve? Does dependabot support yarn catalogs? Adopting catalogs makes sense, just wondering if there's anything we should be aware of. For example, switching to bun if it becomes feasible |
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hey @BarryThePenguin Happy New Year! Looks good to me. Thank you! |
|
🎆 Happy New Year! 🥳 |
No description provided.