Redesign Horde::url() to fix undefined array key errors #42
+34
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove redudant parentheses and do not add '//' in case of empty host.
amulet1
force-pushed
the
fix_host_undefined
branch
from
0416f54 to
c6a203c
Compare
Contributor
Author
|
@TDannhauer Please merge. |
TDannhauer
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove redundant parentheses and do not add '//' in case of empty host.
This is to fix warnings in the log like these:
PHP ERROR: Undefined array key "host" [pid XXXXX on line 564 of ".../vendor/horde/core/lib/Horde.php"]