fix: validate record_count metadata to reject negative values#80
Open
fix: validate record_count metadata to reject negative values#80
Conversation
- Add validated_record_count() mirroring existing validated_file_size() pattern - Apply in table_deletions before constructing DeletedRowsExec - Add assert in DataFileInfo::new() for write-side safety Found during Feb 2026 security review Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Multiple concurrent tests triggering DuckDB's parquet auto-install simultaneously caused flaky failures on macOS CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validated_record_count()function that converts i64 record_count to u64 with proper error handlingDataFileInfo::new()(negative values indicate a programming error)TableDeletionsTablebefore use in delete processingTest plan
validated_record_count()with positive, zero, negative, and i64::MIN valuesDataFileInfo::new()panicking on negative record_countcargo testpasses