fix: validate catalog entity names to reject empty, control chars, and overlength#81
Open
fix: validate catalog entity names to reject empty, control chars, and overlength#81
Conversation
…d overlength - Add shared validate_name() function rejecting empty names, control characters, and names exceeding 1024 characters - Apply to column names (ColumnDef::new, ColumnDef::from_arrow), schema names (get_or_create_schema), and table names (get_or_create_table, validate_table_name, begin_write_transaction) Found during Feb 2026 security review Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zfarrell
force-pushed
the
fix/name-validation
branch
from
c85a329 to
dfc421e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_name()function that rejects empty/whitespace-only names, ASCII control characters, and names exceeding 1024 charactersColumnDef::new()andColumnDef::from_arrow()SqliteMetadataWriter(get_or_create_schema,get_or_create_table,begin_write_transaction)validate_table_name()to share validation logicTest plan
validate_name()with valid names, empty, whitespace, control chars, length limitsColumnDefrejecting empty and control-char names via both constructorsSqliteMetadataWriterrejecting invalid schema/table namescargo testpasses