Fix unit test compilation for learning forests#11
Open
MateusMP wants to merge 1 commit intohpclab:masterfrom
Open
Fix unit test compilation for learning forests#11MateusMP wants to merge 1 commit intohpclab:masterfrom
MateusMP wants to merge 1 commit intohpclab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the class constructor for some of the forest learners were changed but never updated on test.
I don't know if the change on training/validation score was expected, but I think it's understandable if the class implementation changed during the implementation of the new fields.
I ran the tests a few times and they seem to be getting consistent results.
I also included a line in the readme showing how to compile the unit tests.