get_kernel: support specifying the backend
#268
+151
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, `get_kernel` has always auto-detected the backend from the Torch build. However, this causes issues in fixed-device settings where we may want to run some ops on the CPU and others on the GPU. This change allows specifying `backend` as an argument to `get_kernel` and friends. Currently, only the `cpu` backend and the backend that Torch was built for are supported (since we cannot determine the version, etc. of a backend that Torch was not built for). However, we decided to make it a string-based argument as opposed to e.g. a `cpu` bool, in the case Torch might do multi-backend builds in the future.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far,
get_kernelhas always auto-detected the backend from the Torch build. However, this causes issues in fixed-device settings where we may want to run some ops on the CPU and others on the GPU. This change allows specifyingbackendas an argument toget_kerneland friends.Currently, only the
cpubackend and the backend that Torch was built for are supported (since we cannot determine the version, etc. of a backend that Torch was not built for). However, we decided to make it a string-based argument as opposed to e.g. acpubool, in the case Torch might do multi-backend builds in the future.