Remove linux commands, respect tls_skip_insecure as completionParam and set correct arch on amd64#17
Open
badbyte7 wants to merge 8 commits intohuggingface:mainfrom
Open
Remove linux commands, respect tls_skip_insecure as completionParam and set correct arch on amd64#17badbyte7 wants to merge 8 commits intohuggingface:mainfrom
badbyte7 wants to merge 8 commits intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the
runCommandpart to kotlin/java code, so that thellm-lsdownload also works under windows, and ifcurlis not installed (newer Ubuntu verions). It also respects proxy and certificate settings.In my two tested Ubuntu versions the architecture was
amd64, where nollm-lsis available. I added a hardcoded conversion tox86_64.I also realised, that the
llm-lshas atls_skip_verify_insecureCompletionParameterprepared and the plugin also has the setting, but it was not sent in the completion request to thellm-ls. This setting/parameter will be sent now.The only thing still open are the proxy settings for the
llm-ls. I actually set thehttps_proxyenvironment variable before I launch the Idea, but it would be much nicer, if the plugin could do this to. But up to now I could not read the proxy settings of the IDE.I hope this helps and the quality of the code is ok. ;-)