Populate table of contents using section text instead of ID#235
Open
cosmicmarley17 wants to merge 2 commits intohugolabe:masterfrom
Open
Populate table of contents using section text instead of ID#235cosmicmarley17 wants to merge 2 commits intohugolabe:masterfrom
cosmicmarley17 wants to merge 2 commits intohugolabe:masterfrom
Conversation
Populate the table of contents with the text of the section elements rather than their IDs. This corrects the error on the Wikipedia main page (https://en.wikipedia.org/wiki/Main_Page) where the anchor IDs do not represent the expected section names. (Issue hugolabe#232)
Since the TOC is populated with the section line instead of its ID, formatting tags like `<i> ... </i>` are displayed. But if markup is enabled in the GtkLabel, then the formatting tags are applied. This also preserves meaning from italicized words in the section names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a small change to address #232:
Use the section text ("line") values to populate the table of contents, rather than their IDs.
The section text may include style tags (e.g.
<i> ... </i>), so markup formatting is enabled with theuse-markupproperty. It's actually parsing it as Pango, but most of the basic HTML style tags are included in Pango.