Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
ddf2683
feat: add functions to remove and add impute
Gero1999 Feb 4, 2025
b8eb907
testing: add tests for interval_remove_impute
Gero1999 Feb 4, 2025
9d48e88
feat: allow PKNCAdata$intervals as a data input
Gero1999 Feb 7, 2025
7bd6bb8
fix: interval_remove_impute; remove library & return, warn if no $imp…
Gero1999 Feb 8, 2025
cad3882
refactor: interval_remove_impute / target_groups as a data.frame input
Gero1999 Feb 8, 2025
1a4b4d2
feat: interval_add_impute takes df inputs (data, targe_groups) & crea…
Gero1999 Feb 8, 2025
75f7cf1
feat: include arg allow_duplication to interval_add_impute
Gero1999 Feb 8, 2025
bee905a
fix: target_params only params changed for impute. Also keep interval…
Gero1999 Feb 9, 2025
67f7d8b
tests: refine tests for the changes in the function and add new ones
Gero1999 Feb 9, 2025
b210bfe
fix: new_rows_after_original in intervals_add_impute
Gero1999 Feb 9, 2025
d7411a1
tests: add missing test for new_rows_after_original in intervals_add_…
Gero1999 Feb 9, 2025
e0d54a4
move: test-intervals_support_funs.R to tests/testthat
Gero1999 Feb 9, 2025
c490275
style: namespace all dplyr functions
Gero1999 Feb 9, 2025
a85d816
style: remove PKNCA namespacing
Gero1999 Feb 9, 2025
51bfe48
refactor: make functions S3 methods. adjust tests for warnings/errors
Gero1999 Feb 9, 2025
dec1962
refactor: order functions in the script alphabetically
Gero1999 Feb 9, 2025
c56b61a
fix: file duplicate from previous commit
Gero1999 Feb 9, 2025
5e7ddf0
style: clean code based on code factor feedback
Gero1999 Feb 9, 2025
3e736cd
documentation: roxygenise new functions
Gero1999 Feb 9, 2025
c17ce48
documentation: add a news message in new features
Gero1999 Feb 9, 2025
dd149dc
fix: column name in intervals/PKNCAconc for tests
Gero1999 Feb 9, 2025
751a926
fix: add namespacing to dplyr functions in tests
Gero1999 Feb 9, 2025
f49e066
fix: add namespacing to all dplyr functions
Gero1999 Feb 9, 2025
d9cb492
fix: prevent a expected warning to produce an issue in tests
Gero1999 Feb 9, 2025
4feab5a
fix: example in documentation for interval_add_impute
Gero1999 Feb 9, 2025
673745e
refactor: substitute dynamic calls with dplyr & limit documentation l…
Gero1999 Feb 9, 2025
0124aa0
fix: simplify general S3 fun, remove checking tests, update news
Gero1999 Feb 10, 2025
4343e6f
refactor: interval_add_impute / substitute dplyr, removed unwanted args
Gero1999 Feb 11, 2025
26d2e74
tests: interval_add_impute adapted to new error messages and defaults
Gero1999 Feb 11, 2025
8db55b2
fix, refactor: consider NA params, change PKNCAdata$impute strategy, …
Gero1999 Feb 12, 2025
7c6077b
refactor: substitute Vectorize fun with Bill's fun (test: returns "" …
Gero1999 Feb 12, 2025
cfd2bad
fix: typpo in substituted fun add_impute_method
Gero1999 Feb 12, 2025
84e1dd4
documentation: update manuals interval_add_impute & interval_remove_i…
Gero1999 Feb 12, 2025
29d9a6e
documentation: create manuals for add_impute_method & remove_impute_m…
Gero1999 Feb 12, 2025
9217ac6
fix: solve example typpo/args, refactor class evaluation, update manuals
Gero1999 Feb 12, 2025
a89ee52
fix, tests: no matching interval & add_impute when method is already …
Gero1999 Feb 15, 2025
56bebd9
documentation: roxygenise
Gero1999 Feb 15, 2025
f012d74
fix: remove redundant conditional in the function
Gero1999 Feb 15, 2025
d3d13f8
test: add helper functions tests for code coverage
Gero1999 Feb 15, 2025
b9747e5
documentation: solve news warning-issue in subtitle
Gero1999 Feb 15, 2025
23ba77d
documentation, fix: document ... argument & improve missing impute case
Gero1999 Feb 15, 2025
6d27838
fix: consider test also for data.frame with missing impute column
Gero1999 Feb 15, 2025
e952d6a
update: new developed funs
Gero1999 Mar 29, 2025
a1c91fe
refactor: remove PKNCA namespace
Gero1999 Mar 29, 2025
672a199
fix: use NA instead of FALSE for intervals parameter columns
Gero1999 Mar 29, 2025
8b876d2
update: improved tests using describe and it
Gero1999 Mar 29, 2025
3a58074
documentation: roxygenise
Gero1999 Mar 29, 2025
c16ebaf
lintr: remove trailing whitespaces
Gero1999 Mar 29, 2025
6174adf
rename: intervals_support_funs > intervals_support
Gero1999 Mar 29, 2025
7df5761
Merge branch 'main' into 379-interval_support_functions
Gero1999 Mar 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ S3method(group_by,PKNCAresults)
S3method(inner_join,PKNCAconc)
S3method(inner_join,PKNCAdose)
S3method(inner_join,PKNCAresults)
S3method(interval_add_impute,PKNCAdata)
S3method(interval_add_impute,data.frame)
S3method(interval_remove_impute,PKNCAdata)
S3method(interval_remove_impute,data.frame)
S3method(is_sparse_pk,PKNCAconc)
S3method(is_sparse_pk,PKNCAdata)
S3method(is_sparse_pk,PKNCAresults)
Expand Down Expand Up @@ -148,6 +152,8 @@ export(inner_join)
export(interp.extrap.conc)
export(interp.extrap.conc.dose)
export(interpolate.conc)
export(interval_add_impute)
export(interval_remove_impute)
export(is_sparse_pk)
export(left_join)
export(mutate)
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,13 @@ the dosing including dose amount and route.
* `group_vars()` methods were added for `PKNCAdata` and `PKNCAresults` objects.
* If intervals have attributes on the columns, there will no longer be an error
during parameter calculation, and the attributes are preserved (#381)
* New functions are available to simplify the modification of intervals:
`intervals_add_impute()`, `intervals_remove_impute()` (#384)
* When adding units, if some but not all units are provided, then an error will
be raised. This error can be converted to a warning using the option
`allow_partial_missing_units = TRUE`. (#398)

# Minor changes (unlikely to affect PKNCA use)
## Minor changes (unlikely to affect PKNCA use)

* PKNCA will now verify the `intervals` data.frame when creating PKNCAdata. The
checking includes confirming intended column naming and ensuring the correct
Expand Down
Loading