Skip to content

Conversation

@Gero1999
Copy link
Contributor

@Gero1999 Gero1999 commented Oct 31, 2025

Closes #433

Description

  • Defined the calculation of Excretion Rate parameters and used column conc.duration for rate calculations. The functions are: pk.calc.ertmax, pk.calc.ermax and pk.calc.ertlst
  • Refactored checking for missing volume and conc in pk.calc.ae and used it for the new functions created
  • Created tests with 100% coverage

Definition of Done

  • Tmax excretion rate: "ERTMAX", "Time of Max Excretion Rate"
  • Max excretion rate: "ERMAX", "Max Excretion Rate" ( = Amount excreted / Time (end - start))
  • Midpoint last: "MIDPTLST", "Midpoint of Collection Interval" ERTLST, "Midpoint of Interval of Last Nonzero ER"

@Gero1999 Gero1999 changed the title 433 excretion parameters part2 Add excretion rate parameters (#433) Oct 31, 2025
@Gero1999 Gero1999 marked this pull request as ready for review October 31, 2025 12:36
Copy link
Member

@billdenney billdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very near what we will want! Thank you!

@Gero1999 Gero1999 requested a review from billdenney November 11, 2025 06:12
Copy link
Member

@billdenney billdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, please. (Thank you for sticking with this.)

@Gero1999 Gero1999 marked this pull request as draft November 24, 2025 05:29
@Gero1999 Gero1999 marked this pull request as ready for review November 24, 2025 05:42
@Gero1999 Gero1999 requested a review from billdenney November 24, 2025 05:42
@billdenney billdenney merged commit e241322 into humanpred:main Nov 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: add Urine / Excretion Parameters

2 participants