Add rectangle and ellipse tools #118
Conversation
|
I'll look into this issue this weekend! |
hunkim98
left a comment
hunkim98
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing the pull request. The features you have added is working well! May I ask you to write a code for getBresenhamEllipseIndices if you have time? Thanks!
|
I think it is time we use a factory/strategy method to arrange the tools. This will allow other developers create new tools easily! You may proceed to merge the code to the main branch! |
|
No worries. Thanks for the review! Can you do the honors of merging the PR and creating a new npm release? I don't have the privileges. |
|
Sure! Will do now |
You mean a test? OK. I might come back with more contributions and will see if I can write one then. :-) |
|
Published! |
2 participants
🚀 [Resolves #103]
Preview
Changes
This PR adds four new tools to draw rectangles and ellipses (filled and unfilled variants, respectively). Uses a variation of Bresenham's Midpoint circle algorithm to draw ellipses and a simple custom algorithm to draw rectangles.
It also removes the hover pixel preview when drawing a rectangle, ellipse or line as well as when using the selection tool.