Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LEEHAEHYUK
approved these changes
Mar 30, 2025
hyeonjiroh
reviewed
Mar 30, 2025
| import { useForm } from "react-hook-form"; | ||
| import { zodResolver } from "@hookform/resolvers/zod"; | ||
| import Input from "@/components/common/input/Input"; | ||
| import { AuthLayout } from "@/app/(before-login)/(without-navbar)/layout"; |
Owner
There was a problem hiding this comment.
layout.tsx는 따로 import 해줄 필요 없이 children인 페이지의 레이아웃이 됩니다. 이 import 부분 삭제해보신 뒤 문제 없는지 확인해보시고, 문제 없다면 지워도 될 것 같습니다!
hyeonjiroh
reviewed
Mar 30, 2025
| @@ -4,35 +4,56 @@ import { zodResolver } from "@hookform/resolvers/zod"; | |||
| import Input from "@/components/common/input/Input"; | |||
| import { AuthLayout } from "@/app/(before-login)/(without-navbar)/layout"; | |||
Owner
There was a problem hiding this comment.
이 부분도 위에서 말한 것 같이 지워도 괜찮을 것 같습니다!
hyeonjiroh
reviewed
Mar 30, 2025
| localStorage.setItem("accessToken", response.accessToken); | ||
| openAlert("loginSuccess"); | ||
| router.push("/mydashboard"); | ||
| } catch (error: unknown) { |
hyeonjiroh
reviewed
Mar 30, 2025
| try { | ||
| const response = await fetchLogin(data); | ||
| setIsLoading(false); | ||
| localStorage.setItem("accessToken", response.accessToken); |
Owner
There was a problem hiding this comment.
localStorage에 액세스 토큰을 저장하는군요. 로그아웃 기능 구현할 때 참고하겠습니다!
hyeonjiroh
approved these changes
Mar 30, 2025
Owner
hyeonjiroh
left a comment
hyeonjiroh
left a comment
There was a problem hiding this comment.
코드도 깔끔하게 잘 짜시고, 기능 구현도 완벽하네요! zod 라이브러리를 사용해서 유효성 검사를 하신 점이 인상 깊었습니다. 정말 고생 많으셨어요!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
#75
📝 요약
🛠️ PR 유형
##스크린샷
스크린샷은 용량 이슈로 제 클라우드에 올려뒀습니다.
http://naver.me/FG7XcVkT