Merged
Conversation
…#104/dashboard-edit-page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codeit-kkm
approved these changes
Mar 31, 2025
ARON-Y
approved these changes
Mar 31, 2025
| id, | ||
| }); | ||
|
|
||
| window.location.replace(`/dashboard/${id}`); |
Collaborator
There was a problem hiding this comment.
window.location.replace() 대신 router.push() 사용하는 방법도 있대요!
window.location.replace()는 페이지를 새로고침하고 히스토리를 덮어쓰지만, router.push()는 SPA(Single Page Application) 내에서 URL을 변경하면서 페이지 전환을 관리하고 히스토리에 기록할 수 있는 차이점이 있다고 합니당
| totalPages: number; | ||
| onPageChange: (page: number) => void; | ||
| onPrevClick: () => void; | ||
| onNextClick: () => void; |
Collaborator
There was a problem hiding this comment.
페이지 끝으로 가면 버튼 비활성화 하는 disabled나 rest props를 활용해도 좋을것같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
#110
📝 요약
대시보드 수정
/dashboard/{dashboardid})로 이동초대 내역 목록
대시보드 삭제
🛠️ PR 유형