Conversation
This will let us start servers with the correct mode and respond with errors in HTML or in JSON, depending on the use case. A future improvement would be to do this via a middleware: and detect the mode based off the the client's "Accept" header.
Member
Do you mean something like
I think Servant already support detecting the "Accept" header and I've used it here in |
Collaborator
Author
|
@noteed putting this on hold until further research based on today's discussion. |
2a544a7 to
af29a16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for the user error response fixes.
May need minor adjustments based on actual use (which I'm working on next).
--
This will let us start servers with the correct mode and respond with
errors in HTML or in JSON, depending on the use case.
A future improvement would be to do this via a middleware: and detect
the mode based off the the client's "Accept" header.