Conversation
borislaviv
commented
Mar 11, 2025
borislaviv
commented
- moved networking to bridged mode with exposed ports - my Intel Mac refused to expose ports otherwise
- Aligned entityid with the one hadcoded in tests
- Updates to package-lock.json
- moved networking to bridged mode with exposed ports - my Intel Mac refused to expose ports otherwise - Aligned entityid with the one hadcoded in tests https://github.com/hyperscience/forms/blob/98f2330ba30959ce4938c188e8dcf1a8906953ab/forms/user_profile/tests/test_saml_auth.py#L42 - Updates to package-lock.json
| ADD ./public public | ||
|
|
||
| ENTRYPOINT [ "node", "app.js", "--acs", "http://localhost:8080/saml2/acs", "--aud", "http://localhost:8080/", "--host", "0.0.0.0" ] No newline at end of file | ||
| ENTRYPOINT [ "node", "app.js", "--acs", "http://localhost:8080/saml2/acs", "--aud", "http://devops-testing-master01.int.hyperscience.com/", "--host", "0.0.0.0" ] No newline at end of file |
There was a problem hiding this comment.
Based on the docs at https://hyperscience.atlassian.net/wiki/spaces/TECH/pages/2785247427/Local+development+with+SAML
the idea is to be able to run the app locally with this Dockerfile, as opposed to running the tests.
Personally, I don't have a huge preference to one or the other (last time I believe I needed to run both) to be the default. If you decide to keep this change, please update the docs in the wiki as well.
It'd be ideal if we somehow make it easy to run both local tests & local app & CI tests, though not sure how :)
There was a problem hiding this comment.
As long as we have a consistent aud/Entity ID, it should be fine. Reminder that the entity ID is just a string that the service provider and the identity provider use to make sure they're talking to each other, which usually defaults to the service provider URL.
3 participants
