Optimization to avoid excessing reflection #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashkolluru
requested review from
a team,
findingrish,
laxmanchekka and
ravisingal
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=========================================
Coverage 80.39% 80.39%
- Complexity 1149 1150 +1
=========================================
Files 101 101
Lines 4437 4438 +1
Branches 414 414
=========================================
+ Hits 3567 3568 +1
Misses 675 675
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
findingrish
approved these changes
Jul 31, 2021
skjindal93
reviewed
Jul 31, 2021
| // This may be too expensive when being done at a large scale(like in the case of | ||
| // AttributeValue). | ||
| // By using an existing empty builder to create a new builder we are bypassing the reflection | ||
| AttributeValue.Builder valueBuilder = AttributeValue.newBuilder(ATTRIBUTE_VALUE_BUILDER); |
Contributor
There was a problem hiding this comment.
That's interesting to know!
skjindal93
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimization for bypassing the newBuilder() in Avro classes uses SpecificData.getForSchema which uses reflection(Class.forName) for loading the class