-
Notifications
You must be signed in to change notification settings - Fork 137
chore(platform): bump lima version #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Lima dependency from version 1.2.1 to 2.0.2. While this appears to be a simple version bump, it's a major version change that carries a high risk of introducing breaking changes that could impact the custom Lima driver script. Additionally, the mise.lock file has been reformatted, which includes removing the size attribute from several tool definitions, slightly reducing the robustness of artifact verification. I've added a critical comment regarding the potential breakage from the Lima upgrade and a medium-severity comment on the lock file change.
| [tools] | ||
| # runtime | ||
| "asdf:CrouchingMuppet/asdf-lima" = "1.2.1" # using lima from asdf since the aqua one fails to install in CI | ||
| "asdf:CrouchingMuppet/asdf-lima" = "2.0.2" # using lima from asdf since the aqua one fails to install in CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping asdf-lima from 1.2.1 to 2.0.2 is a major version upgrade. Major version updates often include breaking changes to command-line arguments, configuration formats, or output formats. Given that apps/agentstack-cli/src/agentstack_cli/commands/platform/lima_driver.py relies on limactl's specific behavior (e.g., for list --format=json), this change introduces a significant risk of breaking the platform functionality. Without corresponding updates to the driver, this upgrade is likely to cause runtime failures. This change should either be reverted, or the necessary updates to lima_driver.py should be included in this pull request to ensure compatibility.
| checksum = "sha256:0570263812089120bc2a5d84f9e65cd0c25e4a4d724c80075c357239c74ae904" | ||
| size = 1337349 | ||
| url = "https://github.com/sharkdp/fd/releases/download/v10.3.0/fd-v10.3.0-aarch64-apple-darwin.tar.gz" | ||
| "platforms.macos-arm64" = { checksum = "sha256:0570263812089120bc2a5d84f9e65cd0c25e4a4d724c80075c357239c74ae904", url = "https://github.com/sharkdp/fd/releases/download/v10.3.0/fd-v10.3.0-aarch64-apple-darwin.tar.gz"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reformatting of the lock file has removed the size attribute for several tool artifacts (e.g., for fd, gum, helm, etc.). While the checksum ensures integrity, the size attribute provides a useful secondary check against issues like truncated downloads. Removing this check weakens the overall verification process. If the mise tool still supports this attribute, it should be retained for better robustness.
Signed-off-by: Radek Ježek <radek.jezek@ibm.com>
fe06666 to
4c89cb6
Compare
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.