Skip to content

Conversation

@tomkis
Copy link
Collaborator

@tomkis tomkis commented Dec 29, 2025

Summary

Introduces proper handling of settings extension in the CLI

Linked Issues

Fixes #1524

Documentation

  • No Docs Needed:

No docs needed - the CLI reference is unchanged.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 29, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tomkis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the CLI's agent execution capabilities by implementing a robust mechanism for handling agent settings extensions. It enables users to interactively configure agent-specific parameters before an agent run, ensuring that agents can be tailored to specific operational needs directly from the command line. The changes integrate new UI components for collecting settings input and ensure these configurations are correctly passed to the agent's execution context.

Highlights

  • New UI Settings Handling: Introduced a new asynchronous function, _ask_settings_questions, which interactively prompts the user for agent settings directly within the CLI using inquirer. This function supports various field types, including checkbox groups and single-select options.
  • Integration of Settings into Agent Execution: The _run_agent function has been updated to accept an optional AgentRunSettings parameter. These settings are then properly serialized and included in the agent's platform_extension_spec when messages are sent, allowing agents to be configured with user-defined parameters.
  • Comprehensive Interaction Mode Support: The logic for detecting, rendering, and applying agent settings has been integrated across all interaction modes (MULTI_TURN, SINGLE_TURN, and default execution paths) within the run_agent function, ensuring consistent behavior regardless of how the agent is invoked.
  • Dependency Updates: New imports from agentstack_sdk.a2a.extensions.ui.settings have been added to support the new settings functionality, including types like AgentRunSettings, SettingsExtensionSpec, and various field value types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces handling for the settings extension in the CLI. The changes are mostly in apps/agentstack-cli/src/agentstack_cli/commands/agent.py. My review focuses on improving code structure and maintainability. I've pointed out some duplicated code that should be refactored, suggested making some logic more explicit for future-proofing, and recommended cleaning up imports. Overall, the changes look good and address the intended feature.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2026
tomkis added 2 commits January 8, 2026 13:11
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
@tomkis tomkis force-pushed the fix/1524-settings-extension-support-in-cli branch from 2a2a059 to 1677f6d Compare January 8, 2026 12:11
@tomkis tomkis merged commit db483a2 into main Jan 8, 2026
10 checks passed
@tomkis tomkis deleted the fix/1524-settings-extension-support-in-cli branch January 8, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

settings extension not working in CLI

3 participants