-
Notifications
You must be signed in to change notification settings - Fork 137
fix: handling settings extension in the CLI properly #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tomkis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the CLI's agent execution capabilities by implementing a robust mechanism for handling agent settings extensions. It enables users to interactively configure agent-specific parameters before an agent run, ensuring that agents can be tailored to specific operational needs directly from the command line. The changes integrate new UI components for collecting settings input and ensure these configurations are correctly passed to the agent's execution context. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces handling for the settings extension in the CLI. The changes are mostly in apps/agentstack-cli/src/agentstack_cli/commands/agent.py. My review focuses on improving code structure and maintainability. I've pointed out some duplicated code that should be refactored, suggested making some logic more explicit for future-proofing, and recommended cleaning up imports. Overall, the changes look good and address the intended feature.
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
2a2a059 to
1677f6d
Compare
Summary
Introduces proper handling of settings extension in the CLI
Linked Issues
Fixes #1524
Documentation
No docs needed - the CLI reference is unchanged.