Skip to content

chore(packages): patch deps and use built-in solid type#4

Merged
eyelly-wu merged 6 commits intoi18n-pro:mainfrom
onx2:main
May 5, 2025
Merged

chore(packages): patch deps and use built-in solid type#4
eyelly-wu merged 6 commits intoi18n-pro:mainfrom
onx2:main

Conversation

@onx2
Copy link
Contributor

@onx2 onx2 commented Jun 11, 2024

I'd like to chip away at updating some dependencies and minor changes if that's okay with you.

  • Use npx npm-check-updates --target patch -u to patch all dependencies
  • Use ParentProps exported type from solid-js for children prop instead of custom implementation
  • Use splitProps from solid-js to prevent any reactivity loss issues
  • Use boolean flag instead of number for clearer intent and less memory
  • Resolves Can't be used around solid-js/router #3

This seems to work now for me when I tested locally.

render(
  () => (
    <I18nProvider {...i18nState}>
      <Router root={App}>{routes}</Router>
    </I18nProvider>
  ),
  document.getElementById("root")!
);

@onx2 onx2 marked this pull request as ready for review June 11, 2024 16:31
@eyelly-wu
Copy link
Contributor

@onx2 Thank you for your contribution. I was going to merge your PR, but the current performance shows that it does not pass the test cases. Please make sure the test cases pass before trying again.

@eyelly-wu
Copy link
Contributor

@onx2 Hey bro, there hasn't been any progress since the test cases failed on your last PR. Do you have time to finish fixing this issue? If you're too busy, I'll just merge it and handle the test case problems myself. Looking forward to your reply, and thanks again for your contribution.

@onx2
Copy link
Contributor Author

onx2 commented May 2, 2025

@onx2 Hey bro, there hasn't been any progress since the test cases failed on your last PR. Do you have time to finish fixing this issue? If you're too busy, I'll just merge it and handle the test case problems myself. Looking forward to your reply, and thanks again for your contribution.

Hey, sorry for the late response! Hopefully I’ll have some time this weekend to check it out

@eyelly-wu
Copy link
Contributor

@onx2 Hey bro, there hasn't been any progress since the test cases failed on your last PR. Do you have time to finish fixing this issue? If you're too busy, I'll just merge it and handle the test case problems myself. Looking forward to your reply, and thanks again for your contribution.

Hey, sorry for the late response! Hopefully I’ll have some time this weekend to check it out

Alright, looking forward to you getting it done.

@eyelly-wu eyelly-wu merged commit 68727d5 into i18n-pro:main May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't be used around solid-js/router

2 participants