chore(packages): patch deps and use built-in solid type#4
chore(packages): patch deps and use built-in solid type#4eyelly-wu merged 6 commits intoi18n-pro:mainfrom
Conversation
|
@onx2 Thank you for your contribution. I was going to merge your PR, but the current performance shows that it does not pass the test cases. Please make sure the test cases pass before trying again. |
|
@onx2 Hey bro, there hasn't been any progress since the test cases failed on your last PR. Do you have time to finish fixing this issue? If you're too busy, I'll just merge it and handle the test case problems myself. Looking forward to your reply, and thanks again for your contribution. |
Hey, sorry for the late response! Hopefully I’ll have some time this weekend to check it out |
Alright, looking forward to you getting it done. |
I'd like to chip away at updating some dependencies and minor changes if that's okay with you.
npx npm-check-updates --target patch -uto patch all dependenciesParentPropsexported type fromsolid-jsforchildrenprop instead of custom implementationsplitPropsfromsolid-jsto prevent any reactivity loss issuesThis seems to work now for me when I tested locally.