Skip to content

Fix compilation warnings seen with gcc14. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scott-snyder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compilation warnings seen with gcc14. #4

scott-snyder wants to merge 1 commit into from

Conversation

@scott-snyder
Copy link

@scott-snyder scott-snyder commented May 17, 2024

  • Misleading indentation.
  • Unused variables.
  • Use numeric_limits rather than hardcoding limits for int64_t. Fixes in passing a warning that a constant is too large to be represented as a signed integer.
  • Member function parameter shadowing a data member, and variable shadowing variable in outer scope.
  • Extraneous trailing semicolon.

BEGINRELEASENOTES

  • Fix a number of compilation warnings seen with recent compiler versions.
    ENDRELEASENOTES

Fix compilation warnings seen with gcc14.
2b5815c 
- Misleading indentation.
- Unused variables.
- Use numeric_limits rather than hardcoding limits for int64_t.  Fixes in
  passing a warning that a constant is too large to be represented as
  a signed integer.
- Member function parameter shadowing a data member, and variable
  shadowing variable in outer scope.
- Extraneous trailing semicolon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@scott-snyder