Fix compiler warnings and change LCIO_LIBRARIES
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
changed the title
LCIO_LIBRARIES to LCIO::lcioLCIO_LIBRARIES
tmadlener
reviewed
Sep 10, 2025
Contributor
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
I suspect this will break pretty much all iLCSoft packages that use Marlin as this has been handled rather sloppily in the past.
Plus it will probably also break quite a few packages that we do not build within the stack.
| ParseException() { /*no_op*/ ; } | ||
| public: | ||
| virtual ~ParseException() throw() { /*no_op*/; } | ||
| virtual ~ParseException() noexcept { /*no_op*/; } |
Contributor
There was a problem hiding this comment.
Suggested change
| virtual ~ParseException() noexcept { /*no_op*/; } | |
| virtual ~ParseException() noexcept = default; |
And similar below?
Contributor
Author
|
Yes, this would be very painful, there are too many packages that don't build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
using namespacein headers and a few other warningsENDRELEASENOTES
These changes are not trivial since repositories like k4MarlinWrapper depending on Marlin will have to be updated too.