Make project Android independent. Switch to RxJava#5
Open
naixx wants to merge 2 commits intoiainconnor:masterfrom
Open
Make project Android independent. Switch to RxJava#5naixx wants to merge 2 commits intoiainconnor:masterfrom
naixx wants to merge 2 commits intoiainconnor:masterfrom
Conversation
Owner
|
The purpose of I added it to fulfill the specific example in an application I'm using this library in where we cache the current logged in user, and then periodically poll the API to refresh all of their information (in case they changed their avatar or something). So, we need SoftCachedObject as a moment-of-no-return to fetch their user id and re-retrieve that model from the API. |
Author
|
So, one method returns two types of objects? Wouldn't it be better to have separate method to check and explicitly return object of type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is question about SoftCachedObject and its usefullness