Skip to content

Comments

DEBIT#4

Open
larigaldie-n wants to merge 4 commits intoianhussey:mainfrom
larigaldie-n:DEBIT
Open

DEBIT#4
larigaldie-n wants to merge 4 commits intoianhussey:mainfrom
larigaldie-n:DEBIT

Conversation

@larigaldie-n
Copy link

Added an example for the DEBIT tool, that was in the todo list.

Otherwise vignettes are not accessible to users
Added DEBIT on top of GRIMM and GRIMMER. Used the same file because it's also a consistency test, and it's also grouped together in the Scrutiny package
Added DEBIT on top of GRIMM and GRIMMER. Used the same file because it's also a consistency test, and it's also grouped together in the Scrutiny package
# Conflicts:
#	vignettes/GRIM_GRIMMER_DEBIT.Rmd
@lhdjung
Copy link

lhdjung commented Mar 6, 2024

Thanks, but keep in mind that DEBIT has an extremely narrow use case. I think it's fine here, but in other materials, maybe we should focus more on GRIM and GRIMMER as they are much more widely applicable. (I presented all three equally in scrutiny because those docs are meant to be comprehensive instead of pointing users to the most important tools.)

Also, I might tweak the formatting later to use restore_zeros_df() instead of manual solutions.

@larigaldie-n
Copy link
Author

Yes, I agree. To explain my though process: despite the narrow use case, I think it also makes sense from the users' perspective to have them grouped together (at least on the main menu). Since they're doing more or less the same things (on different kinds of data), I think it maximizes discoverability and easy understanding.

Completely agree on using restore_zeros_df(). Otherwise it might become confusing to the shallow reader in the long run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants