Trails #71
Open
Trails #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing TrailNodes in Actions to objects instead of strings
Added actions to hkgraph
eltonfss
reviewed
Jun 29, 2022
package.json
Outdated
| "request-promise-native": "^1.0.8", | ||
| "shortid": "^2.2.14" | ||
| "shortid": "^2.2.14", | ||
| "linked-list": "git+ssh://git@github.ibm.com:keg-core/linked-list.git" |
Contributor
There was a problem hiding this comment.
I believe this might be a problem. As this is a public library it should not refer no any private dependency.
eltonfss
suggested changes
Jun 29, 2022
Contributor
eltonfss
left a comment
eltonfss
left a comment
There was a problem hiding this comment.
I believe the linked-list dependency should be moved to a public repository before being referenced in this package. One alternative would be to include it within this repository.
added 2 commits
June 30, 2022 16:59
marcelomachado
requested changes
Jul 1, 2022
marcelomachado
requested changes
Jul 1, 2022
marcelomachado
requested changes
Jul 1, 2022
Member
marcelomachado
left a comment
marcelomachado
left a comment
There was a problem hiding this comment.
Why are we putting an entire project inside hklib instead of using the npm package?
If it is really necessary I would prefer to put this in a util folder instead of the src root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.