Skip to content

fix formatting strings in zfcp_ping and zfcp_show #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharkcz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix formatting strings in zfcp_ping and zfcp_show #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef0c19
tools: use %lx format for WWPN
sharkcz May 22, 2025
b9aff7b
tools: typecast temp variable to uint32_t
sharkcz May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fc_tools/zfcp_ping.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ HBA_STATUS send_fc_ping(struct adapter_attr *aa, char *dest, unsigned int token,
}

if (display_detail & VERBOSE)
printf("Sending PNG from BUS_ID=0.0.%x WWPN=0x%016llx "
printf("Sending PNG from BUS_ID=0.0.%x WWPN=0x%016lx "
"ID=0x%x dev=%s speed=%s\n", aa->bus_id, aa->wwpn,
aa->d_id, aa->dev_name, speed[aa->speed]);
else
Expand Down Expand Up @@ -180,7 +180,8 @@ HBA_STATUS send_fc_ping(struct adapter_attr *aa, char *dest, unsigned int token,
(*tp)++, update_ts(&start, &end));
else
printf("\techo received from D_ID (0x%x) "
"tok=%d time=%0.03f ms\n", dest_val,
"tok=%d time=%0.03f ms\n",
(uint32_t)dest_val,
(*tp)++, update_ts(&start, &end));
sleep(1);
count--;
Expand Down
2 changes: 1 addition & 1 deletion fc_tools/zfcp_show.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ int main(int argc, char *argv[]) {
if (aa) {
if (display_detail & VERBOSE)
printf("Using adapter BUS_ID 0.0.%x\n"
" Name 0x%016llx\n"
" Name 0x%016lx\n"
" N_Port_ID 0x%x\n"
" OS-Device %s\n"
" Speed %s\n",
Expand Down