Normalize output format handling (-t) to match input (-f)#12
Open
alerque wants to merge 1 commit intoickc:masterfrom
Open
Normalize output format handling (-t) to match input (-f)#12alerque wants to merge 1 commit intoickc:masterfrom
alerque wants to merge 1 commit intoickc:masterfrom
Conversation
5f33e9f to
43712aa
Compare
Pull Request Test Coverage Report for Build 42
💛 - Coveralls |
Contributor
Author
|
I'm not familiar with testing frameworks in python and am not sure what, if anything, needs to be done about the coverage issue. Feedback welcome. |
Contributor
Author
|
Rebased to resolve merge conflict... |
Contributor
Author
|
Travis failure appears to be related to #13 again. I think this is working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
There were a couple logic problems.
--toargument were getting clobbered by file name guessingargs.toandoutput_format. They were used in different places and it was possible for them to be out of sync, causing unexpected results.This normalizes the whole mess on one variable (args.to_format) and handles setting it just like
--frominstead of ... differently. The only place other variables are used is in passing arguments to panflute, which apparently wants named arguments in a slightly different format.I have not been able to test this very exhaustively with all the backends and situations that might be affected. Please proceed with caution on this one, and if something needs fixing I'd be happy to do it.
Depending on what order you merge this or #11 might need to be rebased before merging. Feel free to do ether one and I'll update the PR for the other.