Open
Conversation
danielfeismann
added
the
dependencies
danielfeismann
requested review from
sebastian-peter and
staudtMarius
as code owners
# Conflicts: # build.gradle
# Conflicts: # CHANGELOG.md
Member
|
@danielfeismann I think this pr and the coresponding issue can be closed because of #677. |
Member
Author
|
When that one is finalised,yes... however I'm not sure if we should take the effort to switch just for the sake of it. |
# Conflicts: # CHANGELOG.md
Member
|
With the switch we can more easily edit the config. The config itself can also be simplified. In addition, the config generation is not working, because we are missing the dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #659