Draft
Conversation
Member
Author
|
Some parts that causes the issue we discussed here has been handled here. This is at least my understanding of the problem and a partial solution. However, I think updating the LV nodes directly, as I did, causes new problems, such as loads losing their nodes. This can be encountered when running a simulation. It is most likely that the update of subnetNo for the lvNodes needs to be done by the changesMap. However, that one quickly becomes very large and often contains non-changing entries. Which may can be improved? (see #681) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #680