Align temperature processing in CosmoTimeBasedWeatherValueFactory#1522
Open
pierrepetersmeier wants to merge 14 commits intodevfrom
Open
Conversation
…use Kelvin units for ground temperature values, ensuring consistency with standard temperature units. Added null-checks before unit conversion in both Cosmo and Icon factories to prevent NullPointerException when processing time steps with missing temperature values.
2 tasks
danielfeismann
requested changes
Jan 22, 2026
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Some little hints how to handle the additional issues you discovered. Please also do not forget the changelog entry.
src/main/java/edu/ie3/datamodel/io/factory/timeseries/IconTimeBasedWeatherValueFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/timeseries/CosmoTimeBasedWeatherValueFactory.java
Outdated
Show resolved
Hide resolved
.../groovy/edu/ie3/datamodel/io/factory/timeseries/CosmoTimeBasedWeatherValueFactoryTest.groovy
Outdated
Show resolved
Hide resolved
…o-and-icon-timebasedweathervaluefactories
…n units, adding null-checks to prevent NullPointerException for missing temperature values. Update tests to reflect changes in exception handling for missing temperature fields.
danielfeismann
requested changes
Jan 29, 2026
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
And please add some changelog entry
.../groovy/edu/ie3/datamodel/io/factory/timeseries/CosmoTimeBasedWeatherValueFactoryTest.groovy
Outdated
Show resolved
Hide resolved
...t/groovy/edu/ie3/datamodel/io/factory/timeseries/IconTimeBasedWeatherValueFactoryTest.groovy
Outdated
Show resolved
Hide resolved
...t/groovy/edu/ie3/datamodel/io/factory/timeseries/IconTimeBasedWeatherValueFactoryTest.groovy
Outdated
Show resolved
Hide resolved
.../groovy/edu/ie3/datamodel/io/factory/timeseries/CosmoTimeBasedWeatherValueFactoryTest.groovy
Outdated
Show resolved
Hide resolved
…n units, adding null-checks to prevent FactoryException for missing temperature values. Update tests to reflect changes in exception handling.
Removed duplicate entry for temperature processing alignment in Cosmo and Icon factories.
Removed duplicate entry for temperature processing alignment in Cosmo and Icon factories.
… temperature handling and exception management. Update tests to ensure proper behavior when required fields are empty.
…ssing-of-cosmo-and-icon-timebasedweathervaluefactories' into pp/#1521-align-temperature-processing-of-cosmo-and-icon-timebasedweathervaluefactories
…to verify handling of missing temperature values. Update assertions to check for expected results instead of throwing exceptions.
…o-and-icon-timebasedweathervaluefactories
Corrected capitalization of 'Kelvin' in temperature processing alignment.
…o-and-icon-timebasedweathervaluefactories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the temperature parsing logic in CosmoTimeBasedWeatherValueFactory with the Icon factory. Temperature inputs are now interpreted as Kelvin and converted to Celsius.
Resolves #1521