Add option to use local files instead of download.#257
Open
staudtMarius wants to merge 17 commits intomainfrom
Open
Add option to use local files instead of download.#257staudtMarius wants to merge 17 commits intomainfrom
staudtMarius wants to merge 17 commits intomainfrom
Conversation
Contributor
|
!test |
jo-bao
reviewed
Aug 15, 2024
Contributor
jo-bao
left a comment
jo-bao
left a comment
There was a problem hiding this comment.
It looks good to me at all! Just some remarks.
But @sebastian-peter has some other comments?
danielfeismann
requested changes
Dec 6, 2024
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Had a first view here, but I guess the merge conflicts need to be solved first
…d-of-download # Conflicts: # build.gradle # src/main/resources/config-template.conf # src/main/scala/edu/ie3/simbench/config/SimbenchConfig.scala # src/main/scala/edu/ie3/simbench/main/RunSimbench.scala
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
- Coverage 63.42% 63.15% -0.28%
==========================================
Files 70 70
Lines 2097 2133 +36
Branches 51 51
==========================================
+ Hits 1330 1347 +17
- Misses 767 786 +19 ☔ View full report in Codecov by Sentry. |
…d-of-download # Conflicts: # src/main/scala/edu/ie3/simbench/main/RunSimbench.scala
…d-of-download # Conflicts: # src/main/scala/edu/ie3/simbench/config/ConfigValidator.scala # src/main/scala/edu/ie3/simbench/config/SimbenchConfig.scala # src/main/scala/edu/ie3/simbench/main/RunSimbench.scala # src/test/scala/edu/ie3/simbench/io/ExtractorSpec.scala
staudtMarius
requested review from
danielfeismann
and removed request for
jo-bao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #256