Conversation
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 62.21% 62.15% -0.07%
==========================================
Files 69 69
Lines 1985 1971 -14
Branches 14 14
==========================================
- Hits 1235 1225 -10
+ Misses 750 746 -4
Continue to review full report at Codecov.
|
…e than one rated voltage.
Utkarsha-dev05
changed the title
ckittl
left a comment
ckittl
left a comment
There was a problem hiding this comment.
Additionally, I would wish for an integration test, that checks, what you have fixed. So having two source lines with the same type, but different voltage level and then checking if the right ones are selected.
| - Basic functionality to convert SimBench data sets to [PowerSystemDataModel](https://github.com/ie3-institute/powersystemdatamodel) | ||
|
|
||
| ### Changed | ||
| - Line type can be mapped to more than one vRated voltage. |
There was a problem hiding this comment.
The CHANGELOG should be cumulative. That means, that you please keep, what is written under [1.0.0] and add your Changed part beneath Unreleased
inputData/config/EHV.conf
Outdated
| @@ -0,0 +1,26 @@ | |||
| io { | |||
There was a problem hiding this comment.
Please remove the config. Those files should be kept locally.
| NodeConverter.getNodes(acLine.nodeA, acLine.nodeB, nodes) | ||
| val lineType = types.getOrElse( | ||
| acLine.lineType, | ||
| (acLine.lineType, Quantities.getQuantity(acLine.nodeA.vmR, KILOVOLT)), |
There was a problem hiding this comment.
Here we use a composite key to access a map. However, the second part (the voltage) is set up from Doubles. Thus, it could be error prone. Maybe you may add a warning comment, that this only works, if you don't do any calculations with the voltage, that you provide here.
| } | ||
| ), | ||
| Duration("10 s") | ||
| Duration("100 s") |
There was a problem hiding this comment.
Please don't commit this, as it was just an adaption to make it run on your PC.
…uration" in SimbenchReader.
…warning comment in LineConverter.
2 participants
Resolves #57