fix: Handle non-UTF-8 characters in ABNF parser stderr output#626
Merged
kesara merged 1 commit intoietf-tools:mainfrom Feb 16, 2026
Merged
Conversation
Add errors="ignore" parameter to stderr.decode() calls in both extract_abnf() and parse_abnf() functions to prevent crashes when the BAP tool outputs non-UTF-8 characters in error messages. This fixes UnicodeDecodeError exceptions that occurred when stderr contained invalid UTF-8 bytes (e.g., 0xe2, 0x96). The stdout decode calls already had this error handling; this change makes stderr handling consistent. Fixes ietf-tools#284, Fixes ietf-tools#530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
errors="ignore"parameter tostderr.decode()calls in the ABNF parser to prevent crashes when BAP tool outputs non-UTF-8 characters.Changes
at/utils/abnf.py:errors="ignore"to stderr decode inextract_abnf()errors="ignore"to stderr decode inparse_abnf()Problem
The application was crashing with
UnicodeDecodeErrorwhen the BAP (ABNF parser) tool output non-UTF-8 characters in stderr. The stdout decode calls already haderrors="ignore"error handling, but stderr decode calls did not.Example errors:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 2298UnicodeDecodeError: 'utf-8' codec can't decode byte 0x96 in position 0Solution
Made stderr decoding consistent with stdout decoding by adding the
errors="ignore"parameter. This allows the decoder to skip or replace invalid UTF-8 sequences instead of raising an exception.Testing
errors="ignore"Related Issues