Fixed one memory leak#90
Open
kelno wants to merge 1 commit intoike3:trinity-wotlk-aifrom
kelno:patch-1
Open
Conversation
Destructors of class inheriting from ChatFilter did not get called
ike3
pushed a commit
that referenced
this pull request
Apr 10, 2022
* Fix .ticket response & .ticket close handling - Now the GMTicket::SetResponseText method will save the response to the right ticket and will nor update all ticket responses for the same character - Fix potential issue in GMTicketMgr::Create : limiting to the the most recent ticket of the player and avoid potential multiple returns if there is inconsistent data in table - Fix GMTicket::SetText - Prevent to update ticket_text for old tickets of the same char when submiting ticket or updating ticket text in game - Fix item_text GUID generation - Setting system response when ticket closed without mail response - Create a PSendSysMessageMultiline function , will split a mangos string in multiple lines if "@@" string is found. * Fix revision.h after structure change Need apply Rel21_16_053_GM_tickets_handling_fixes.sql in order to work correctly
ike3
pushed a commit
that referenced
this pull request
Jul 3, 2022
…for MangosZero (#90) * Command reorg Co-authored-by: Elmsroth <pieric62@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destructors of classes inheriting from ChatFilter did not get called.
For example:
RtiChatFilter has a member
list<std::string> rtis;which was never destroyed.