Potential fix for code scanning alert no. 2: Uncontrolled data used in path expression #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ilesinge/shabda/security/code-scanning/2
To fix the problem, sanitize and validate the
languageargument before using it in the file path. The best approach, given its use as part of a filename, is either to restrict it to a safe set of values or ensure only safe characters are included. For this use-case, we can eliminate any directory traversal (/,\, or..) and restrict to a simple whitelist (e.g., letters, digits, underscore, dash), or usewerkzeug.utils.secure_filenameor a similar utility for ensuring the segment is safe for file use.Specifically, edit the
speakmethod inshabda/dj.pyto sanitizelanguage(and potentiallywordandgendersimilarly). You can do this using a regular expression or by filtering out unwanted characters. Since onlylanguageis tainted in the trace, we must at least sanitize it before constructing the file path. Add the necessary imports.Suggested fixes powered by Copilot Autofix. Review carefully before merging.