-
Notifications
You must be signed in to change notification settings - Fork 27
Mostly replace font-size($step) SASS mixin with equivalent CSS classes
#8997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Mostly replace font-size($step) SASS mixin with equivalent CSS classes
#8997
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
f771fe7 to
0437cb5
Compare
|
The mixin has been extinguished, but the second-to-last commit, uh, commits a grievous error: simply adding the new shared class's attributes to a bunch of deeply-nested places that I couldn't yet figure out how to untangle. |
9a386ed to
941140e
Compare
font-size($step) SASS mixin with equivalent CSS classesfont-size($step) SASS mixin with equivalent CSS classes
941140e to
229f6df
Compare
|
the remaining usage of these mixins. |
stopfstedt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor shifts, padding related i think, that the differ and Percy caught.
i'm ok with that.
…ke a couple exceptions in shared font-size file, however
…ded class to main component
…ppropriate font-size-x class where it was used
…mixins, as well as some other various places
…ease at best, and inconsistent font-size with the year picker next to it at worst
… TODO fix this so it uses the font-size shared class
…me tricky spots we do not have a solution for yet
229f6df to
42b17d0
Compare
Refs ilios/ilios#6608
Fixes ilios/ilios#6710
This is a biggie, and will be done in several passes:
I'm trying to keep commits generally within those boundaries so my journey can be properly followed along with.