GH-146: Minor refactoring and readability improvements across the codebase

[imDMK]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @imDMK, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the internal architecture and maintainability of the project through significant refactoring of the configuration management and dependency injection systems. It also includes improvements to Gradle dependency declarations for better module isolation and API exposure, along with numerous minor code cleanups to boost overall code quality and readability. The changes aim to make the codebase more robust, easier to understand, and simpler to extend in the future.

Highlights

• Configuration Management Refactoring: The internal configuration management system has been significantly refactored. This includes the introduction of new internal classes like ConfigFactory, ConfigBinder, ConfigLifecycle, and YamlConfigurerFactory to streamline config creation, binding, and lifecycle operations. The main ConfigManager now acts as a facade, delegating these responsibilities to the new components.
• Dependency Injection Annotation Renaming: The @BindCore annotation and its corresponding binder class PlayTimeCoreBinder have been renamed to @Bind and PlayTimeBinder respectively, improving clarity and consistency within the dependency injection framework.
• Gradle Dependency Configuration Improvements: Gradle build files have been updated to use compileOnlyApi for API dependencies and api for transitive project dependencies, ensuring correct dependency exposure and reducing redundant declarations. Several compileOnly dependencies were removed from playtime-plugin as they are now correctly handled by other modules.
• Standardized Null Check Messages: Null check messages across various Validator.notNull calls have been standardized and simplified, making error messages more concise and consistent.
• Reload Command Enhancement: The ReloadCommand now utilizes TaskScheduler for asynchronous configuration loading and includes robust error handling for OkaeriException during the reload process.
• Minor Code Cleanup and Readability: Various minor code cleanups were performed, including removing trailing semicolons, adjusting field visibility in message configs from public to package-private, removing redundant this. prefixes, and reformatting constructor parameters for improved readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a nice set of cleanups and readability improvements across the codebase. The refactoring of the ConfigManager is a significant improvement, simplifying its API and separating concerns into smaller, more focused classes. The dependency updates and formatting changes also contribute to better code quality.

I've added a couple of suggestions:

• One is to fix an outdated reference in a Javadoc to keep the documentation consistent with the code changes.
• The other is to improve the exception messages from the Validator.notNull method to make them more descriptive, which will aid in debugging.

[imDMK]

/gemini review

[gemini-code-assist]

Code Review

This pull request is a large-scale refactoring that significantly improves the codebase's structure, maintainability, and readability. Key improvements include breaking down large classes like ConfigManager and DatabaseConnector into smaller, more focused components, which enhances separation of concerns. The package structure has been reorganized for better clarity, and many classes have been moved to more appropriate locations. Additionally, there are consistent improvements in code style, such as better variable naming, use of final, and more descriptive exception messages. The command registration and database initialization logic have been simplified and cleaned up. Overall, this is an excellent set of changes that modernizes the codebase and makes it easier to maintain. I have only one minor suggestion regarding a missing newline at the end of a file.