Open
Conversation
robquill
reviewed
Aug 5, 2020
robquill
left a comment
robquill
left a comment
There was a problem hiding this comment.
Have given some feedback on grammar fixes. Ultimately depends on contributor's license signed off by Legal.
| Notes for optional components should go in separate files. | ||
| --> | ||
|
|
||
| This guide walks through cross-compiling IREE core runtime towards the embedded |
There was a problem hiding this comment.
Suggest: "for an embedded Linux platform"
Comment on lines
+13
to
+14
| Cross-compilation involves both a *host* platform and a *target* platform. One | ||
| invokes compiler toolchains on the host platform to generate libraries and |
There was a problem hiding this comment.
Suggest: "The compiler toolchain on the host platform is used to generate..."
| invokes compiler toolchains on the host platform to generate libraries and | ||
| executables that can be run on the target platform. | ||
|
|
||
| The following steps will use aarch64 as the embedded platform. These steps has |
| --> | ||
|
|
||
| This guide walks through using qemu-user to build the core compiler and runtime | ||
| parts of IREE towards the embedded linux platform. |
There was a problem hiding this comment.
Suggest: "for an" instead of "towards the"
| This guide walks through using qemu-user to build the core compiler and runtime | ||
| parts of IREE towards the embedded linux platform. | ||
|
|
||
| The following steps will use aarch64 as the embedded platform. These steps has |
| ### Prepare Folders Shared between Host and Rootfs | ||
|
|
||
| It is very convenient to have some shared folders between the host and the | ||
| aarch64 rootfs, this example creates iree source and build folder on the host, |
There was a problem hiding this comment.
Maybe a full-stop instead of a comma. I.e. "...rootfs. This example creates..."
|
|
||
| It is very convenient to have some shared folders between the host and the | ||
| aarch64 rootfs, this example creates iree source and build folder on the host, | ||
| then bind it to the aarch64 rootfs. |
| ### Prepare Folders Shared between Host and Rootfs | ||
|
|
||
| It is very convenient to have some shared folders between the host and the | ||
| aarch64 rootfs, this example creates iree source and build folder on the host, |
There was a problem hiding this comment.
IREE instead of iree? Some places in the file have it capitalised, some don't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add document for iree cross compilation and qemu based compilation.