Open
Conversation
Most of the changes were made to allow this code to be built on travis-ci, a free continous integration service. Notably, the code had to make sure to close stdin when forking a process. In one of the tests comparing json documents, the test was changed to use a sorted csv of json properties. A direct comparison using just diff produces wrong results, as json properties are unordered.
Author
|
The build representing this commit can be found here: https://travis-ci.org/ambakshi/istatd/builds/67796367 The README.md is referencing my fork's travis-ci job. Please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the changes were made to allow this code to be
built on travis-ci, a free continous integration service.
Notably, the code had to make sure to close stdin when
forking a process. In one of the tests comparing json
documents, the test was changed to use a sorted csv of
json properties. A direct comparison using just diff produces
wrong results, as json properties are unordered.