[TASK] respect sender.default.senderEmail for sender mail TO fallback#742
Open
jpmschuler wants to merge 3 commits intoin2code-de:masterfrom
Open
[TASK] respect sender.default.senderEmail for sender mail TO fallback#742jpmschuler wants to merge 3 commits intoin2code-de:masterfrom
jpmschuler wants to merge 3 commits intoin2code-de:masterfrom
Conversation
Contributor
Author
|
closed as more detailed tests fail, will reopen as soon as stable |
a31ca4e to
43b5957
Compare
Collaborator
|
Hi @jpmschuler Thanks for your contribution. This makes totally sense. Would you mind to rebase it onto the current master and make it compatible with TYPO3 v12. I'd really appreciate it. |
Contributor
Author
|
Can look into it during my migration to 12LTS in the next days and weeks, so no clear ETA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current powermail 8.4.1 I have a form with empty
settings.flexform.sender.email(yay editors) and sender mail enabled. Now the email is send to the server admin email address (dunno taken from which setting yet).For the recipient email I can define the
plugin.tx_powermail.settings.setup.receiver.default.senderEmailand theplugin.tx_powermail.settings.setup.receiver.emailFor the sender email doing the same the
plugin.tx_powermail.settings.setup.sender.emailandplugin.tx_powermail.settings.setup.sender.default.senderEmailgets ignored thus the TO falls back to my server admin email address.The code shows a lookup for
senderNamebut not forsenderEmail, thus I propose to copy that code for senderEmail, too.