You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for leaving this hanging for such a long time ... I'm still a bit unsure about this one.
I'm totally pro not running arakoon as root, but the same could be said about not running with fsync=true (which is an even worse thing to do imo).
So I think that we want to handle both cases in the same way ... wether that's the warning in the log or refusing to start -- unless a certain env variable or tainted config setting is present.
Btw is there a reason here to prefer an env variable over a tainted config setting?
I wouldn't implement this using some warning in a log: nobody will ever see that anyway.
I used an environment variable instead of a configuration setting because
Unlike the fsync thing, this isn't related to how an Arakoon node operates at runtime. It's meant to prevent any runtime at all.
I figure some would without any hesitation add __tainted_run_as_root = true to their Arakoon configuration file template. Managing environment variables might be slightly harder depending on the deployment system in use.
When using the work-around, it's more clear at the location of the exec call one is doing something fishy.
So do you think we should be less lenient in the fsync case?
I know it's not exactly the same thing but I'm interested in your opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.