Skip to content

Conversation

@adamdickmeiss
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the Debian package from SysV init to systemd for service management. The changes replace the traditional init script with a modern systemd service unit file and update all related packaging scripts to work with systemd.

Changes:

  • Introduced systemd service file (debian/metaproxy.service) with proper service configuration
  • Removed legacy SysV init script (debian/metaproxy.init) and related init.d configurations
  • Updated postinst, postrm, and logrotate scripts to use systemd commands instead of init.d mechanisms
  • Consolidated configuration files by moving user/service variables from metaproxy.user into metaproxy.default

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
debian/rules Removed metaproxy.user file copying and added dh_installsystemd override to enable systemd integration
debian/metaproxy.service New systemd unit file defining service behavior, dependencies, and execution parameters
debian/metaproxy.postrm Removed update-rc.d cleanup call as systemd handles service removal automatically
debian/metaproxy.postinst Changed to source /etc/default/metaproxy, added cleanup of old init.d script, replaced init.d service start with systemd daemon-reload
debian/metaproxy.logrotate Updated postrotate hook to use systemctl instead of PID file-based HUP signal
debian/metaproxy.install Removed metaproxy.user from installation list as it's no longer needed
debian/metaproxy.init Removed entire 180-line SysV init script as it's replaced by systemd service
debian/metaproxy.default Restructured to include both user configuration and OPTIONS variable for systemd service

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adamdickmeiss and others added 2 commits January 12, 2026 14:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants